kv/kvserver split incoming snapshot user keys into multiple sstables #104426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
raggar
force-pushed
the
rahul_split_user_keys
branch
from
a588777
to
7379d29
Compare
We ingest a fixed number of sstables, corresponding to the range's various contiguous keyspaces. When the default range size increased from 64 MB to 512 MB, we started ingesting larger user data sstables which negatively impacts compation. This change creates a new sstable if the current one is too large (greater than 128MiB). When the default range size increased from 64 MB to 512 MB, we started ingesting user data sstables up to 512 MB. Release note: None Fixes: cockroachdb#67284
raggar
force-pushed
the
rahul_split_user_keys
branch
from
7379d29
to
dd74e67
Compare
|
to be replaced by: #106771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ingest a fixed number of sstables, corresponding to the range's various contiguous keyspaces. When the default range size increased from 64 MB to 512 MB, we started ingesting larger user data sstables which negatively impacts compation. This change creates a new sstable if the current one is too large (greater than 128MiB).
Release note: None
Fixes: #67284
TODO: