Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: unify and harden crdb_internal.cluster_inflight_traces #106326

Merged
merged 1 commit into from
Jul 11, 2023

Commits on Jul 7, 2023

  1. server: unify and harden crdb_internal.cluster_inflight_traces

    This commit unifies population of
    `crdb_internal.cluster_inflight_traces` between single-tenant and
    multi-tenant modes - from now on, in all deployment modes we use all
    available SQL instances to fetch span recordings from. The trace
    collector has been refactored accordingly.
    
    Additionally, the trace collector is hardened to ignore any errors
    that are encountered when retrieving recordings from a single SQL
    instance (previously, it would fail if we encountered an error when
    dialing the SQL instance or when receiving GetSpanRecordingResponse,
    and now we will log a warning and proceed silently). The rationale
    for making this change is that instances might no longer be "ready"
    when the iteration reaches them, so this should make the virtual
    table generation more bullet-proof.
    
    Release note: None
    yuzefovich committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    5f0cd35 View commit details
    Browse the repository at this point in the history