stmtdiagnostics: fix upload in face of transaction retry #106812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
5 tasks
stevendanna
force-pushed
the
stmt-diagnostic-txn-retry-error
branch
from
71b88be to
79838cf
Compare
lidorcarmel
approved these changes
Jul 14, 2023
stevendanna
force-pushed
the
stmt-diagnostic-txn-retry-error
branch
from
79838cf to
cd988b6
Compare
Previously, the bundle insert transaction would upload an empty bundle in the face of a transaction retry because it both read from and wrote to the same slice variable inside the retriable transaction function. Here, we make a new slice header to track the upload progress, leaving the original intact in case of retry. Note that this was caught via synthetic testing and hasn't been seen in the wild as far as I know. Epic: none Release note: None
stevendanna
force-pushed
the
stmt-diagnostic-txn-retry-error
branch
from
cd988b6 to
70ab058
Compare
|
bors r=lidorcarmel |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the bundle insert transaction would upload an empty bundle
in the face of a transaction retry because it both read from and wrote
to the same slice variable inside the retriable transaction function.
Here, we make a new slice header to track the upload progress, leaving
the original intact in case of retry.
Note that this was caught via synthetic testing and hasn't been seen
in the wild as far as I know.
Epic: none
Release note: None