Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: teamcity-trigger: don't start a job for an empty target #107818

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 28, 2023

Backport 1/1 commits from #107802 on behalf of @rickystewart.

/cc @cockroachdb/release


This makes no sense, so skip these cases.

Closes: #107779
Closes: #107780
Closes: #107781

Epic: none
Release note: None


Closes: #107852

Release justification: Test-only code change

@blathers-crl blathers-crl bot requested a review from a team as a code owner July 28, 2023 18:26
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107802 branch from b575a64 to d6b6841 Compare July 28, 2023 18:26
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 28, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107802 branch from 97ca04b to 12c04e2 Compare July 28, 2023 18:26
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart requested a review from rail July 28, 2023 18:29
@rickystewart rickystewart force-pushed the blathers/backport-release-23.1-107802 branch 2 times, most recently from d9ab9f2 to 59547fb Compare July 31, 2023 21:40
This makes no sense, so skip these cases.

Closes: #107779
Closes: #107781

Epic: none
Release note: None
@rickystewart rickystewart force-pushed the blathers/backport-release-23.1-107802 branch from 59547fb to 75721d4 Compare August 1, 2023 14:34
@rickystewart rickystewart merged commit 0d1323b into release-23.1 Aug 1, 2023
@rickystewart rickystewart deleted the blathers/backport-release-23.1-107802 branch August 1, 2023 16:00
@renatolabs renatolabs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants