Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudccl: allow external connection tests to be run in parallel #108465

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented Aug 9, 2023

Currently external connection tests read and write to the same path in cloud storage. Add a random uint64 as part of the path so that test runs have unique paths and can be run in parallel.

Fixes: #107407

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rhu713 rhu713 marked this pull request as ready for review August 9, 2023 18:12
@rhu713 rhu713 requested a review from a team as a code owner August 9, 2023 18:12
@rhu713 rhu713 requested review from msbutler and removed request for a team August 9, 2023 18:12
@rhu713 rhu713 added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Aug 9, 2023
Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Could you do one test run via TC to confirm everything passes?

pkg/ccl/cloudccl/amazon/s3_connection_test.go Outdated Show resolved Hide resolved
pkg/ccl/cloudccl/amazon/s3_connection_test.go Outdated Show resolved Hide resolved
Currently external connection tests read and write to the same path in cloud
storage. Add a random uint64 as part of the path so that test runs have unique
paths and can be run in parallel.

Fixes: cockroachdb#107407

Release note: None
Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you trigger one run the nightlies just to make sure everything passes?

@rhu713
Copy link
Contributor Author

rhu713 commented Aug 10, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 10, 2023

Build succeeded:

@craig craig bot merged commit 1f8fa96 into cockroachdb:master Aug 10, 2023
2 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Aug 10, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 38f086c to blathers/backport-release-22.2-108465: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/ccl/cloudccl/amazon/amazon_test: TestS3ExternalConnection failed
3 participants