Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: roachtest: fix qps parse in kvrestart test #113717

Merged
merged 1 commit into from
Nov 28, 2023
Merged

release-23.2: roachtest: fix qps parse in kvrestart test #113717

merged 1 commit into from
Nov 28, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 2, 2023 •
edited by kvoli
Loading

Backport 1/1 commits from #113681 on behalf of @kvoli.

/cc @cockroachdb/release

The kv/restart/nodes=12 test could fail when failing to parse the QPS metric value into a uint64. Parse as a float64, then later convert.

Epic: none
Release note: None

Release justification: Test only change.

@kvoli
roachtest: fix qps parse in kvrestart test
bc873c5 
The `kv/restart/nodes=12` test could fail when failing to parse the QPS
metric value into a uint64. Parse as a float64, then later convert.

Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 2, 2023 21:30
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113681 branch from ef4b0db to f147e27 Compare November 2, 2023 21:30
@blathers-crl blathers-crl bot requested review from herkolategan and DarrylWong and removed request for a team November 2, 2023 21:30
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 2, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113681 branch from fc92e3b to bc873c5 Compare November 2, 2023 21:30
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Nov 2, 2023 •
edited by kvoli
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 2, 2023
@blathers-crl blathers-crl bot requested a review from srosenberg November 2, 2023 21:30
@cockroach-teamcity
Copy link
Member

This change is Reviewable

andrewbaptist
andrewbaptist approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment •
edited by cockroach-dev-inf
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@kvoli
Copy link
Collaborator

kvoli commented Nov 28, 2023

TYFTR

@kvoli kvoli merged commit 6f863f1 into release-23.2 Nov 28, 2023
5 of 6 checks passed
@kvoli kvoli deleted the blathers/backport-release-23.2-113681 branch November 28, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbaptist andrewbaptist andrewbaptist approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan was automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong was automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs

@srosenberg srosenberg Awaiting requested review from srosenberg

Assignees

@kvoli kvoli

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @kvoli @andrewbaptist