-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: roachtest: randomly run with runtime assertions by default #113894
release-23.1: roachtest: randomly run with runtime assertions by default #113894
Conversation
This changes the semantics of `t.Cockroach()` to use a binary with runtime assertions and metamorphic constants enabled by default. Performance tests (indicated by the benchmark TestSpec) will continue using the standard binary, without runtime assertions, as usual. This commit also opts-out other tests that cannot easily be run with runtime assertions or metamorphic constants enabled, most often due to timeouts and metamorphic constant incompatibility. Resolves cockroachdb#86678. Informs cockroachdb#94986. Epic: none Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to delete the lint:ignore SA1019 deprecated
comment since 23.1 is still on Go 1.19.
Thanks for backporting!
Adds a label indicating that a roachtest failure was on a metamorphic build on github issue posts.
8475cb2
to
0b599ee
Compare
Should we hold off on backporting this for now? Let's give it a couple of weeks on master and 23.2 to stabilize first (ideally, we would have done this only on master) so that we can shake issues like #113816 out. |
Yep, we can wait longer; it was my idea to backport given that we had run all tests extensively during development of this feature. Let's wait until next week to merge this backport. |
Backport 2/2 commits from #111949.
/cc @cockroachdb/release
Release justification: test-only changes
This changes the semantics of
t.Cockroach()
to use a binary with runtime assertions enabled by default. Performance tests (indicated by the benchmark TestSpec) will be able to continue using the standard binary, without runtime assertions or metamorphic constants, as usual.This commit also opts-out other tests that cannot easily be run with runtime assertions or metamorphic constants enabled, most often due to timeouts or metamorphic constant incompatibility.
Resolves #86678.
Informs #94986.
Epic: none
Release note: None