Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: sql: only validate new regions when adding/dropping #114102

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 8, 2023

Backport 1/1 commits from #113956 on behalf of @rafiss.

/cc @cockroachdb/release


When we added validation logic to make sure every region corresponded to a known node locality, we were a little too aggressive. The validation made it possible to end up in a state where any ALTER..REGION operation could hang. This could happen in a few situations; for example:

  • node is restarted with a different locality flag.
  • MR cluster is restored into a non-MR cluster.
  • c2c streaming is used with a MR source and non-MR destination.

In all these cases, the problem was that the zone configuration could reference a region that no longer has any nodes with the corresponding locality. The validation was too aggressive, since it would validate those regions which already existed in the zone configuration.

Now, only the newly added region is validated.

fixes #113324
fixes #113871

Release note (bug fix): Fixed a bug that could cause ALTER DATABASE ... ADD/DROP REGION to hang if node localities were changed after regions were added.


Release justification: low risk fix for a serious bug

@blathers-crl blathers-crl bot requested review from a team as code owners November 8, 2023 22:25
@blathers-crl blathers-crl bot requested review from srosenberg and renatolabs and removed request for a team November 8, 2023 22:25
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 8, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113956 branch from 246d885 to 52c015d Compare November 8, 2023 22:25
@blathers-crl blathers-crl bot requested review from dt and removed request for a team November 8, 2023 22:25
Copy link
Author

blathers-crl bot commented Nov 8, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 8, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss force-pushed the blathers/backport-release-23.2-113956 branch from 52c015d to b1ac386 Compare November 8, 2023 22:55
When we added validation logic to make sure every region corresponded to
a known node locality, we were a little too aggressive. The validation
made it possible to end up in a state where any ALTER..REGION operation
could hang. This could happen in a few situations; for example:

- node is restarted with a different locality flag.
- MR cluster is restored into a non-MR cluster.
- c2c streaming is used with a MR source and non-MR destination.

In all these cases, the problem was that the zone configuration could
reference a region that no longer has any nodes with the corresponding
locality. The validation was too aggressive, since it would validate
those regions which already existed in the zone configuration.

Now, only the newly added region is validated.

Release note (bug fix): Fixed a bug that could cause ALTER DATABASE ...
ADD/DROP REGION to hang if node localities were changed after regions
were added.
@rafiss rafiss force-pushed the blathers/backport-release-23.2-113956 branch from b1ac386 to feed5f2 Compare November 9, 2023 20:41
@rafiss rafiss merged commit 57fb269 into release-23.2 Nov 10, 2023
5 of 6 checks passed
@rafiss rafiss deleted the blathers/backport-release-23.2-113956 branch November 10, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants