-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: github-pull-request-make: pass timeout to stress directly #114280
Merged
rickystewart
merged 1 commit into
release-23.2
from
blathers/backport-release-23.2-114269
Nov 15, 2023
Merged
release-23.2: github-pull-request-make: pass timeout to stress directly #114280
rickystewart
merged 1 commit into
release-23.2
from
blathers/backport-release-23.2-114269
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing a lot of timeouts here. I think it's because the test timeouts are being passed incorrectly. If you look at a test run that timed out, the command looks like the following: ``` bazci test ... --test_arg=-test.timeout --test_arg=7m30s --test_timeout=660 ... -maxfails 1 -maxtime 10m0s -p 16 ``` When you look at this, the problem may be obvious: * We tell `stress` to run the test for up to 10 minutes; but * We tell `bazel` the timeout for the test should be 7m30s. In this way, it seems it's obvious tests are timing out. The shorter timeout (7m30s) is meant to represent the timeout for the individual test process under-the-hood. To me that means that we should instead pass the timeout to `stress` as `timeout`, which is what this PR does. Epic: none Release note: None
4b44f67
to
ca2ff57
Compare
7cf78da
to
2322365
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
jlinder
approved these changes
Nov 11, 2023
rail
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #114269 on behalf of @rickystewart.
/cc @cockroachdb/release
We're seeing a lot of timeouts here. I think it's because the test timeouts are being passed incorrectly. If you look at a test run that timed out, the command looks like the following:
When you look at this, the problem may be obvious:
stress
to run the test for up to 10 minutes; butbazel
the timeout for the test should be 7m30s.In this way, it seems it's obvious tests are timing out.
The shorter timeout (7m30s) is meant to represent the timeout for the individual test process under-the-hood. To me that means that we should instead pass the timeout to
stress
astimeout
, which is what this PR does.Epic: none
Release note: None
Release justification: