Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: github-pull-request-make: pass timeout to stress directly #114280

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 10, 2023

Backport 1/1 commits from #114269 on behalf of @rickystewart.

/cc @cockroachdb/release


We're seeing a lot of timeouts here. I think it's because the test timeouts are being passed incorrectly. If you look at a test run that timed out, the command looks like the following:

bazci test ... --test_arg=-test.timeout --test_arg=7m30s --test_timeout=660 ... -maxfails 1 -maxtime 10m0s -p 16

When you look at this, the problem may be obvious:

  • We tell stress to run the test for up to 10 minutes; but
  • We tell bazel the timeout for the test should be 7m30s.

In this way, it seems it's obvious tests are timing out.

The shorter timeout (7m30s) is meant to represent the timeout for the individual test process under-the-hood. To me that means that we should instead pass the timeout to stress as timeout, which is what this PR does.

Epic: none
Release note: None


Release justification:

We're seeing a lot of timeouts here. I think it's because the test
timeouts are being passed incorrectly. If you look at a test run that
timed out, the command looks like the following:

```
bazci test ... --test_arg=-test.timeout --test_arg=7m30s --test_timeout=660 ... -maxfails 1 -maxtime 10m0s -p 16
```

When you look at this, the problem may be obvious:
* We tell `stress` to run the test for up to 10 minutes; but
* We tell `bazel` the timeout for the test should be 7m30s.

In this way, it seems it's obvious tests are timing out.

The shorter timeout (7m30s) is meant to represent the timeout for the
individual test process under-the-hood. To me that means that we should
instead pass the timeout to `stress` as `timeout`, which is what this PR
does.

Epic: none
Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-114269 branch from 4b44f67 to ca2ff57 Compare November 10, 2023 23:52
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 10, 2023 23:52
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 10, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-114269 branch from 7cf78da to 2322365 Compare November 10, 2023 23:52
@blathers-crl blathers-crl bot requested review from kenliu-crl and rail November 10, 2023 23:52
Copy link
Author

blathers-crl bot commented Nov 10, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 10, 2023
Copy link
Author

blathers-crl bot commented Nov 10, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart merged commit 145c0bd into release-23.2 Nov 15, 2023
@rickystewart rickystewart deleted the blathers/backport-release-23.2-114269 branch November 15, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants