-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: roachtest: allow tests to specify a cockroach binary to use #114654
Merged
DarrylWong
merged 4 commits into
cockroachdb:release-23.1
from
DarrylWong:backport23.1-113301
Nov 17, 2023
Merged
release-23.1: roachtest: allow tests to specify a cockroach binary to use #114654
DarrylWong
merged 4 commits into
cockroachdb:release-23.1
from
DarrylWong:backport23.1-113301
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarrylWong
requested review from
herkolategan and
srosenberg
and removed request for
a team
November 17, 2023 17:46
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Nov 17, 2023
Currently, roachtests must manually upload their own cockroach binary if needed through the Put API. However, almost all roachtests upload the standard t.Cockroach() binary to ./cockroach on all nodes, resulting in the same Put code being duplicated at the start of most tests. Additionally, to collect artifacts we still need a cockroach binary at a discoverable path, leading to the same binary being copied twice in many cases, see: cockroachdb#97814 This change adds a TestSpec option which lets tests specify a cockroach binary to use. If one is not specified, we now upload the t.Cockroach() binary to ./cockroach. This lets us remove cockroach-default logic for artifacts, and removes the need to manually upload binaries at the start of each test. Release note: None Fixes: cockroachdb#104729
This change prints the cockroach random seed used by metamorphic builds to test.log for ease of debugging. Before this seed was found only in cockroach.log.
Before if a test uploaded a non t.Cockroach() binary github posting would have no knowledge of that and naively use t.Cockroach() to determine metamorphism or not. This fixes that.
Release note: None
DarrylWong
force-pushed
the
backport23.1-113301
branch
from
November 17, 2023 19:15
0ae0da0
to
823b50d
Compare
srosenberg
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #113301.
/cc @cockroachdb/release
Currently, roachtests must manually upload their own cockroach binary if needed through the Put API.
However, almost all roachtests upload the standard t.Cockroach() binary to ./cockroach on all nodes,
resulting in the same Put code being duplicated at the start of most tests. Additionally, to collect artifacts
we still need a cockroach binary at a discoverable path, leading to the same binary being copied twice in many
cases, see: #97814
This change adds a TestSpec option which lets tests specify a cockroach binary to use. If one is not specified,
we now upload the t.Cockroach() binary to ./cockroach. This lets us remove cockroach-default logic for artifacts,
and removes the need to manually upload binaries at the start of each test.
Release note: None
Fixes: #104729
Release justification: test only change