Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add elastic backup equivalent test for aws #117678

Merged

Conversation

aadityasondhi
Copy link
Collaborator

Informs #107770.

Release note: None

@aadityasondhi aadityasondhi requested a review from a team as a code owner January 11, 2024 14:48
@aadityasondhi aadityasondhi requested review from srosenberg and DarrylWong and removed request for a team January 11, 2024 14:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aadityasondhi aadityasondhi requested a review from a team January 11, 2024 14:49
@aadityasondhi aadityasondhi marked this pull request as draft January 11, 2024 14:49
@aadityasondhi aadityasondhi force-pushed the 20240109.elastic-backup-aws-roachtest branch from 550598a to 4095fb7 Compare January 11, 2024 19:23
@aadityasondhi aadityasondhi marked this pull request as ready for review January 11, 2024 19:24
@aadityasondhi aadityasondhi force-pushed the 20240109.elastic-backup-aws-roachtest branch from 4095fb7 to 91f49b8 Compare January 11, 2024 20:11
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @srosenberg)

Copy link
Collaborator Author

@aadityasondhi aadityasondhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r=sumeerbhola

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @srosenberg)

@craig
Copy link
Contributor

craig bot commented Jan 30, 2024

Build succeeded:

@craig craig bot merged commit b6d1474 into cockroachdb:master Jan 30, 2024
8 of 9 checks passed
@aadityasondhi aadityasondhi deleted the 20240109.elastic-backup-aws-roachtest branch January 30, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants