Arbitrary bit sizes for slots in the counting bloom filter #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax the divisible-by restriction on the number of bits for each slot. I suspect the sweet spot for these things will be 3 bits, so this change seemed worth doing. It was trickier than expected. I created a "visitSlotBytes" method to refactor incrementSlot and getSlot to avoid duplicated code as it had gotten complicated. Fixed visibility issues with filter class.
|
LGTM on the visibility changes. I’ll defer to @strangemonad or @petermattis for the slot stuff. |
This was referenced Apr 12, 2016
andreimatei
added a commit
that referenced
this pull request
Apr 14, 2016
…-diagram change the mailboxes diagram to remove the multiple table readers
soniabhishek
pushed a commit
to soniabhishek/cockroach
that referenced
this pull request
Feb 15, 2017
Added megatron client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the divisible-by restriction on the number of bits for each slot.
I suspect the sweet spot for these things will be 3 bits, so this change
seemed worth doing. It was trickier than expected. I created a
"visitSlotBytes" method to refactor incrementSlot and getSlot to avoid
duplicated code as it had gotten complicated.
Fixed visibility issues with filter class.