Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operations: add a few more variants to the ADD COLUMN op #123424

Merged
merged 1 commit into from
May 8, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented May 1, 2024

This adds some coverage for computed columns and NOT NULL constraints.

fixes #122251
Release note: None

This adds some coverage for computed columns and NOT NULL constraints.

Release note: None
@rafiss rafiss requested review from itsbilal and fqazi May 1, 2024 22:23
@rafiss rafiss requested a review from a team as a code owner May 1, 2024 22:23
@rafiss rafiss requested review from herkolategan and DarrylWong and removed request for a team May 1, 2024 22:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafiss
Copy link
Collaborator Author

rafiss commented May 8, 2024

tftr!

bors r+

@craig craig bot merged commit ba6b500 into cockroachdb:master May 8, 2024
22 checks passed
@rafiss rafiss deleted the add-column-drt-op branch May 9, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: Test schema changes on DRT
4 participants