Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgwire: add a metric for number of pipelined requests #124231

Merged
merged 1 commit into from
May 15, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented May 15, 2024

fixes #123912
Release note (ops change): Added the sql.pgwire.pipeline.count metric, which is a gauge that measures how many wire protocol commands have been received by the server, but have not yet begun processing. This metric will only grow if clients are using the "pipeline mode" of the Postgres wire protocol.

@rafiss rafiss added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. labels May 15, 2024
@rafiss rafiss requested a review from fqazi May 15, 2024 17:29
@rafiss rafiss requested review from a team as code owners May 15, 2024 17:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from a team May 15, 2024 18:04
@rafiss rafiss force-pushed the add-pipeline-metric branch from 8cf4ff8 to 8a4a171 Compare May 15, 2024 18:06
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor question :lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)


pkg/sql/pgwire/conn_test.go line 300 at r1 (raw file):

	require.NoError(t, err)

	testutils.SucceedsSoon(t, func() error {

Is this because we need to wait for the queries above to finish in the pipeline? Could we do GetResults?

Copy link
Collaborator Author

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @fqazi)


pkg/sql/pgwire/conn_test.go line 300 at r1 (raw file):

Previously, fqazi (Faizan Qazi) wrote…

Is this because we need to wait for the queries above to finish in the pipeline? Could we do GetResults?

this is actually needed since we have to wait for the queries to reach the server and get into the pipeline.

GetResults wouldn't work here since the fake server in this test never actually sends results back to the client. and the reason we need a fake server is so that we can control exactly when the stmtBuf is read from.

i'll add some comments

Release note (ops change): Added the sql.pgwire.pipeline.count metric,
which is a gauge that measures how many wire protocol commands have been
received by the server, but have not yet begun processing. This metric
will only grow if clients are using the "pipeline mode" of the Postgres
wire protocol.
@rafiss rafiss force-pushed the add-pipeline-metric branch from 8a4a171 to 2566197 Compare May 15, 2024 21:22
Copy link
Collaborator Author

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @fqazi)

@rafiss
Copy link
Collaborator Author

rafiss commented May 15, 2024

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented May 15, 2024

Already running a review

@craig craig bot merged commit 7d5ffef into cockroachdb:master May 15, 2024
21 of 22 checks passed
Copy link

blathers-crl bot commented May 15, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 2566197 to blathers/backport-release-23.1-124231: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from 2566197 to blathers/backport-release-23.2-124231: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-24.1-124231 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/124256/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: add a metric for number of statements queued in stmtBuf due to pipelining
3 participants