release-24.1: roachtest: use first transient error when checking for flakes #124600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #124403 on behalf of @renatolabs.
/cc @cockroachdb/release
Previously, roachtest would only look at the outermost error in a chain that matched a
TransientError
(orErrorWithOwnership
) when checking for flakes. However, that is in most cases not what we want: if a transient error wraps another transient error, the actual reason for the failure is the original (wrapped) error.Informs: #123887
Release note: None
Release justification: test only change.