-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drt: add date to roachtest_ops.log entries #125350
drt: add date to roachtest_ops.log entries #125350
Conversation
eb90d2e
to
59a77ef
Compare
How do the log entries look like? I wonder if we should just change roachprod's defaults to include |
Something like
We don't see the timestamp but it's UTC by default I think. I thought of adding LDate in defaults but then wasn't sure if we'd want to have the date everywhere. |
@cockroachdb/test-eng anyone opposed to adding |
I'll make the changes |
Previously, roachtest_ops.log entries show the current timestamp in hh:mm:ss without the timezone. This makes correlating logs quite tricky. This patch add date and timezone to the log Fixes: cockroachdb#125304 Release note: None
59a77ef
to
8026da8
Compare
bors r+ |
Previously, roachtest_ops.log entries show the current timestamp in hh:mm:ss without the timezone. This makes correlating logs quite tricky. This patch add date and timezone to the logs.
Fixes: #125304
Release note: None