workload/schemachange: only allow PK change in single statement transactions #128834
Conversation
rafiss
requested review from
herkolategan and
vidit-bhat
and removed request for
a team
|
This change is |
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @annrpom, @herkolategan, @rafiss, and @vidit-bhat)
pkg/workload/schemachange/operation_generator.go line 200 at r1 (raw file):
if numOpsInTxn != 1 { // DML and PK changes are only allowed in single-statement transactions. if isDMLOpType(op) || op == alterTableAlterPrimaryKey {
We should allow this for declarative txns? Those support doing multiple operations
…actions This will avoid errors of the form: "cannot perform other schema changes in the same transaction as a primary key change." Release note: None
rafiss
force-pushed
the
fix-rsw-pk-change
branch
from
6f185a6 to
0c84c13
Compare
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/workload/schemachange/operation_generator.go line 200 at r1 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
We should allow this for declarative txns? Those support doing multiple operations
done
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
3 participants
This will avoid errors of the form: "cannot perform other schema changes in the same transaction as a primary key change."
informs: #128615
Release note: None