workload: add support for exporting histogram file in openmetrics format#129221
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 4, 2024
Merged
workload: add support for exporting histogram file in openmetrics format#129221craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
sambhav-jain-16
force-pushed
the
CRDB-41457
branch
3 times, most recently
from
61e7485 to
45f8dfa
Compare
sambhav-jain-16
force-pushed
the
CRDB-41457
branch
3 times, most recently
from
d7e0f20 to
95095ba
Compare
sambhav-jain-16
requested review from
a team,
csgourav,
nameisbhaskar and
srosenberg
and removed request for
a team
sambhav-jain-16
force-pushed
the
CRDB-41457
branch
5 times, most recently
from
ffcd095 to
d5ae901
Compare
Contributor
Author
|
Example of the metrics emitted as shown in grafana 
|
sambhav-jain-16
force-pushed
the
CRDB-41457
branch
6 times, most recently
from
c40a6db to
2b8dd22
Compare
sambhav-jain-16
force-pushed
the
CRDB-41457
branch
2 times, most recently
from
71ffeef to
dfb02ee
Compare
sambhav-jain-16
added a commit
to sambhav-jain-16/cockroach
that referenced
this pull request
Nov 15, 2024
cockroachdb#129221 and cockroachdb#132023 added changes to exporters to emit openmetrics. This PR makes changes to the roachtests to make use of the changes in the above PRs. This change also made some changes to some roachtests that use neither of the above approaches Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
133035: roachtest: add code changes to benchmarks to emit openmetrics r=nameisbhaskar,DarrylWong a=sambhav-jain-16 #129221 and #132023 added changes to exporters to emit openmetrics. This PR makes changes to the roachtests to make use of the changes in the above PRs. This change also made some changes to some roachtests that use neither of the above approaches Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None Co-authored-by: Sambhav Jain <sambhav.jain@cockroachlabs.com>
sambhav-jain-16
added a commit
to sambhav-jain-16/cockroach
that referenced
this pull request
Nov 19, 2024
cockroachdb#129221 and cockroachdb#132023 added changes to exporters to emit openmetrics. This PR makes changes to the roachtests to make use of the changes in the above PRs. This change also made some changes to some roachtests that use neither of the above approaches Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
sambhav-jain-16
added a commit
to sambhav-jain-16/cockroach
that referenced
this pull request
Nov 19, 2024
cockroachdb#129221 and cockroachdb#132023 added changes to exporters to emit openmetrics. This PR makes changes to the roachtests to make use of the changes in the above PRs. This change also made some changes to some roachtests that use neither of the above approaches Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
sambhav-jain-16
added a commit
to sambhav-jain-16/cockroach
that referenced
this pull request
Nov 26, 2024
cockroachdb#129221 and cockroachdb#132023 added changes to exporters to emit openmetrics. This PR makes changes to the roachtests to make use of the changes in the above PRs. This change also made some changes to some roachtests that use neither of the above approaches Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
sambhav-jain-16
added a commit
to sambhav-jain-16/cockroach
that referenced
this pull request
Nov 26, 2024
cockroachdb#129221 and cockroachdb#132023 added changes to exporters to emit openmetrics. This PR makes changes to the roachtests to make use of the changes in the above PRs. This change also made some changes to some roachtests that use neither of the above approaches Epic: https://cockroachlabs.atlassian.net/browse/CRDB-41852 Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
workloadbinary use--histogramflag to export hdr histogramsinto a json file which is then used by
roachperfto create adashboard.
In efforts of deprecating
roachperfaltogether, we need to move toopenmetrics so that the metrics can be ingested into any sink that
supports openmetrics (prometheus etc). This change adds a new flag
--histogram-export-formatwhich allows the user to choose to export ineither
jsonoropenmetricsformat. Also--openmetrics-labelsflag is added so that appropriate labels can be added for the
openmetrics exporter
This change makes use of
expfmt.MetricFamilyToOpenMetricsfunctionwhich is provided by prometheus library.
Epic: none
Release note: None
Part of: #106662