raft: clean up raftLog entry slice indexing #130980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: none Release note: none
Epic: none Release note: none
Epic: none Release note: none
All raft log slices are constructed in context of being appended after a certain index, so (lo, hi] addressing makes more sense. This also removes the redundant unstable.slice method. Epic: none Release note: none
Epic: none Release note: none
Epic: none Release note: none
|
This change is |
tbg
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
LGTM assuming these commits are identical to https://github.com/cockroachdb/cockroach/pull/130967/commits
|
Yeah, same commits. TFTR! bors r=tbg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up various
raftLog/unstablemethods, and converts the sub-slicing methods to(lo, hi]semantics instead of[lo, hi).All raft log slices are constructed in context of being appended after a certain index, so
(lo, hi]addressing makes more sense, and simplifies a bunch of +-1 arithmetics.Related to #130967, #130955