Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemachanger: disable dsc zone config by default #132678

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

annrpom
Copy link
Contributor

@annrpom annrpom commented Oct 15, 2024

This patch disables zone config statements in the declarative schema changer by default.

Release note: None
Epic: None

@annrpom annrpom requested a review from rafiss October 15, 2024 17:04
@annrpom annrpom requested a review from a team as a code owner October 15, 2024 17:04
Copy link

blathers-crl bot commented Oct 15, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@annrpom annrpom force-pushed the disable-dsc-zc branch 2 times, most recently from 169e812 to d041b82 Compare October 16, 2024 14:15
This patch disables zone config statements in the declarative
schema changer by default.

Release note: None
@annrpom
Copy link
Contributor Author

annrpom commented Oct 17, 2024

TFTR! ('-')7

bors r=rafiss

@craig craig bot merged commit e59f52b into cockroachdb:master Oct 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants