roachtest: add validation for version binary override flag #133191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the help message for this flag had an incorrect example usage that listed the version without the leading `v`. Doing this would cause the override to never be used as the override checked for version with the leading `v`. This change fixes the usage message as well as adds validation that overrided versions are parseable.
|
This change is |
DarrylWong
requested review from
nameisbhaskar and
vidit-bhat
and removed request for
a team
srosenberg
approved these changes
Oct 23, 2024
|
TFTR! bors r=srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the help message for this flag had an incorrect example usage that listed the version without the leading
v. Doing this would cause the override to never be used as the override checked for version with the leadingv.This change fixes the usage message as well as adds validation that overrided versions are parseable.
Release note: none
Fixes: none
Epic: none