-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: metamorphically enable leader leases #133217
roachtest: metamorphically enable leader leases #133217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @nameisbhaskar and @srosenberg)
31cbe20
to
21a6e6b
Compare
I ran a select collection of 18 roachtest which enable metamorphic leases and forced them to use leader leases. All passed on master (ef26d15).
|
21a6e6b
to
09a23c7
Compare
Part of cockroachdb#132762. To increase test coverage of leader leases, this patch adds leader leases to the set of possible lease types when tests opt-in to metamorphic leases. As of fc68b0f, most roachtests do enable metamorphic leases, so this will provide good coverage of leader leases. Release note: None
09a23c7
to
9513109
Compare
TFTR! bors r+ |
Part of #132762.
To increase test coverage of leader leases, this patch adds leader leases to the set of possible lease types when tests opt-in to metamorphic leases. As of fc68b0f, most roachtests do enable metamorphic leases, so this will provide good coverage of leader leases.
Before merging this, we should manually run all of these tests with leader leases to verify that they pass.
Release note: None