Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: metamorphically enable leader leases #133217

Merged

Conversation

nvanbenschoten
Copy link
Member

@nvanbenschoten nvanbenschoten commented Oct 23, 2024

Part of #132762.

To increase test coverage of leader leases, this patch adds leader leases to the set of possible lease types when tests opt-in to metamorphic leases. As of fc68b0f, most roachtests do enable metamorphic leases, so this will provide good coverage of leader leases.

Before merging this, we should manually run all of these tests with leader leases to verify that they pass.

Release note: None

@nvanbenschoten nvanbenschoten added the backport-24.3.x Flags PRs that need to be backported to 24.3 label Oct 23, 2024
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner October 23, 2024 03:24
@nvanbenschoten nvanbenschoten requested review from srosenberg and nameisbhaskar and removed request for a team October 23, 2024 03:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten mentioned this pull request Oct 23, 2024
3 tasks
Copy link
Contributor

@iskettaneh iskettaneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @nameisbhaskar and @srosenberg)

@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/roachtestMetamorphic branch from 31cbe20 to 21a6e6b Compare October 29, 2024 15:37
@nvanbenschoten
Copy link
Member Author

I ran a select collection of 18 roachtest which enable metamorphic leases and forced them to use leader leases. All passed on master (ef26d15).

--- PASS: inconsistency (131.26s)
--- PASS: slow-drain/duration=1m0s (186.65s)
--- PASS: gossip/chaos/nodes=9 (186.76s)
--- PASS: follower-reads/survival=zone/locality=global/reads=bounded-staleness (331.46s)
--- PASS: follower-reads/survival=region/locality=regional/reads=exact-staleness (315.09s)
--- PASS: follower-reads/survival=region/locality=global/reads=strong (326.69s)
--- PASS: follower-reads/survival=zone/locality=regional/reads=exact-staleness (327.78s)
--- PASS: follower-reads/survival=region/locality=regional/reads=bounded-staleness (326.39s)
--- PASS: follower-reads/survival=region/locality=global/reads=exact-staleness (320.59s)
--- PASS: follower-reads/survival=zone/locality=global/reads=exact-staleness (358.88s)
--- PASS: follower-reads/survival=zone/locality=global/reads=strong (324.18s)
--- PASS: follower-reads/survival=region/locality=global/reads=bounded-staleness (343.04s)
--- PASS: follower-reads/survival=zone/locality=regional/reads=bounded-staleness (407.35s)
--- PASS: follower-reads/survival=region/locality=regional/reads=bounded-staleness/insufficient-quorum (519.91s)
--- PASS: follower-reads/survival=zone/locality=regional/reads=bounded-staleness/insufficient-quorum (519.35s)
--- PASS: hotspotsplits/nodes=4 (625.60s)
--- PASS: restart/down-for-2m (894.56s)
--- PASS: follower-reads/mixed-version/survival=region/locality=global/reads=strong (1830.03s)
--- PASS: follower-reads/mixed-version/single-region (2744.32s)

@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/roachtestMetamorphic branch from 21a6e6b to 09a23c7 Compare November 12, 2024 17:05
Part of cockroachdb#132762.

To increase test coverage of leader leases, this patch adds leader leases
to the set of possible lease types when tests opt-in to metamorphic leases.
As of fc68b0f, most roachtests do enable metamorphic leases, so this will
provide good coverage of leader leases.

Release note: None
@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/roachtestMetamorphic branch from 09a23c7 to 9513109 Compare November 12, 2024 19:04
@nvanbenschoten
Copy link
Member Author

TFTR!

bors r+

@craig craig bot merged commit c1a452d into cockroachdb:master Nov 12, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants