Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: roachtest: enable DistSender circuit breakers in failover/partial/lease-leader #133370

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 24, 2024

Backport 1/1 commits from #133214 on behalf of @nvanbenschoten.

/cc @cockroachdb/release


DistSender circuit breakers are useful in this test to avoid artificially inflated latencies due to the way the test measures failover time (pMax, no timeouts). Without circuit breakers, a request stuck on the partitioned leaseholder will get blocked indefinitely, despite the range recovering on the other side of the partition and becoming available to all new traffic. As a result, the test won't differentiate between temporary and permanent range unavailability. We have other tests which demonstrate the benefit of DistSender circuit breakers (especially when applications do not use statement timeouts), so we don't need to test them here.

With this change, the test's meaured failover time drops from:

lease=epoch (ms) lease=expiration (ms) lease=leader (ms)
60,129 60,129 60,129

down to:

lease=epoch (ms) lease=expiration (ms) lease=leader (ms)
60,129 22,549 31,139

This is because the circuit breakers place a 10s timeout on all KV requests, so no request gets stuck indefinitely. Notice that expiration and leader leases now recover, while epoch leases remain unavailable indefinitely.

Epic: None
Release note: None


Release justification: testing only

…se-leader

DistSender circuit breakers are useful in this test to avoid
artificially inflated latencies due to the way the test measures
failover time (pMax, no timeouts). Without circuit breakers, a request
stuck on the partitioned leaseholder will get blocked indefinitely,
despite the range recovering on the other side of the partition and
becoming available to all new traffic. As a result, the test won't
differentiate between temporary and permanent range unavailability. We
have other tests which demonstrate the benefit of DistSender circuit
breakers (especially when applications do not use statement timeouts),
so we don't need to test them here.

With this change, the test's failover time drops from:

| lease=epoch (ms) | lease=expiration (ms) | lease=leader (ms) |
|-----------------:|----------------------:|------------------:|
| 60,129           | 60,129                | 60,129            |

down to:

| lease=epoch (ms) | lease=expiration (ms) | lease=leader (ms) |
|-----------------:|----------------------:|------------------:|
| 60,129           | 22,549                | 31,139            |

Notice that expiration and leader leases now recover, while epoch leases
remain unavailable indefinitely.

Epic: None
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 24, 2024 17:01
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-133214 branch from 3b4b36a to 9fc81db Compare October 24, 2024 17:01
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 24, 2024
@blathers-crl blathers-crl bot requested review from nameisbhaskar, vidit-bhat, arulajmani, DarrylWong, nvanbenschoten and srosenberg and removed request for a team October 24, 2024 17:01
Copy link
Author

blathers-crl bot commented Oct 24, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 24, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten merged commit a5bfb23 into release-24.3 Oct 25, 2024
19 of 21 checks passed
@nvanbenschoten nvanbenschoten deleted the blathers/backport-release-24.3-133214 branch October 25, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants