Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: sql: do not use fast-path-checks if there are row-level BEFORE triggers #134223

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 4, 2024

Backport 1/1 commits from #133330 on behalf of @DrewKimball.

/cc @cockroachdb/release


sql: do not inline INSERT values into checks if there are BEFORE triggers

This commit prevents a possible bug in uniqueness checks when the table has
row-level BEFORE triggers. The issue is an optimization that attempts to
inline INSERT values into the check, to avoid buffering. This inlining
logic uses the input of the INSERT operator before row-level triggers
are added, and so it does not observe any modifications made to the rows.
This could in theory result in the check failing to detect duplicates,
although I was unable to create a logictest to produce this result.

Fixes #133329

Release note: None


Release justification: bug fix for new functionality in 24.3

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-133330 branch from 7ad8666 to 45ef588 Compare November 4, 2024 18:24
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 4, 2024 18:24
@blathers-crl blathers-crl bot requested review from rytaft and removed request for a team November 4, 2024 18:25
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 4, 2024
Copy link
Author

blathers-crl bot commented Nov 4, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 4, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@DrewKimball DrewKimball force-pushed the blathers/backport-release-24.3-133330 branch from 45ef588 to c8b28f0 Compare November 7, 2024 06:38
@DrewKimball
Copy link
Collaborator

@mgartner friendly ping

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball, @mgartner, and @rytaft)

…gers

This commit prevents a possible bug in uniqueness checks when the table has
row-level BEFORE triggers. The issue is an optimization that attempts to
inline INSERT values into the check, to avoid buffering. This inlining
logic uses the input of the INSERT operator *before* row-level triggers
are added, and so it does not observe any modifications made to the rows.
This could in theory result in the check failing to detect duplicates,
although I was unable to create a logictest to produce this result.

Fixes #133329

Release note: None
@DrewKimball DrewKimball force-pushed the blathers/backport-release-24.3-133330 branch from c8b28f0 to 0029093 Compare November 8, 2024 04:13
Copy link
Author

blathers-crl bot commented Nov 8, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@DrewKimball
Copy link
Collaborator

TFTR

@DrewKimball DrewKimball merged commit 093d4f3 into release-24.3 Nov 8, 2024
20 of 21 checks passed
@DrewKimball DrewKimball deleted the blathers/backport-release-24.3-133330 branch November 8, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants