Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3.0-rc: tablemetadatacache,ui: change error messaging for failed tmj update #135092

Conversation

kyle-a-wong
Copy link
Contributor

Backport 1/1 commits from #134902.

/cc @cockroachdb/release


Previously, error messages from the table metaddata update job were surfaced in the UI on the table overview page. These errors are usually overly verbose and don't provide any actionable info to the end user.

In addition to this, error messages can be very big if the error is a result of a span stats fanout failure, which can contain errors for each fanned out request.

Now, db-console will simply report that an error occured in the job and that the data is stale. The error returned from failed SpanStats requests will now have a generic "An error has occurred while fetching span stats."

Epic: None
Release note: None

Old error messaging:
image

New error messaging:
image

Previously, error messages from the table metadata update job
were surfaced in the UI on the table overview page. These errors
are usually overly verbose and don't provide any actionable info
to the end user.

In addition to this, error messages can be very big if the error
is a result of a span stats fanout failure, which can contain
errors for each fanned out request.

Now, db-console will simply report that an error occured in the
job and that the data is stale. The error returned from failed
SpanStats requests will now have a generic "An error has occurred
while fetching span stats."

Epic: None
Release note: None
@kyle-a-wong kyle-a-wong requested a review from a team as a code owner November 13, 2024 18:42
Copy link

blathers-crl bot commented Nov 13, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 13, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kyle-a-wong
Copy link
Contributor Author

Closing PR. This as been backported to release-24.3 and this can wait until 24.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants