crosscluster/physical: update tokens when altering topology#136122
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 26, 2024
Merged
crosscluster/physical: update tokens when altering topology#136122craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
msbutler
approved these changes
Nov 25, 2024
Collaborator
msbutler
left a comment
msbutler
left a comment
There was a problem hiding this comment.
Are you planning to follow up with a change to remove tokens?
Contributor
Author
It isn't currently on my prioritized backlog. |
Contributor
Author
|
But it kills me a little that that the DistSQL plan diagram isn't the source of truth as to what the plan will actually do. |
Release note: none. Epic: none. This regressed in cockroachdb#135637 which was assigning all conusmer sub-partitions the whole partition due to sharing the original token.
Contributor
Author
|
TFTR! bors r+ |
Contributor
This was referenced Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: none.
Epic: none.
This regressed in #135637 which was assigning all conusmer sub-partitions the whole partition due to sharing the original token.