kvserver: use leader leases in various flow control tests#136182
Merged
craig[bot] merged 6 commits intocockroachdb:masterfrom Nov 26, 2024
Merged
kvserver: use leader leases in various flow control tests#136182craig[bot] merged 6 commits intocockroachdb:masterfrom
craig[bot] merged 6 commits intocockroachdb:masterfrom
Conversation
This test sets a very large number for RaftElectionTimeoutTicks to keep leadership sticky. Naively, this prevents us from using leader leases in this test, as replicas won't campaign if they don't have StoreLiveness support, which isn't kicked off until the first tick. Conveniently, raft fortification is yet another way to keep leadership sticky -- so explicitly using leader leases should achieve the same goal. References cockroachdb#133763 Release note: None
This test sets a very large number for RaftElectionTimeoutTicks to keep leadership sticky. Naively, this prevents us from using leader leases in this test, as replicas won't campaign if they don't have StoreLiveness support, which isn't kicked off until the first tick. Conveniently, raft fortification is yet another way to keep leadership sticky -- so explicitly using leader leases should achieve the same goal. References cockroachdb#133763 Release note: None
This test sets a very large number for RaftElectionTimeoutTicks to keep leadership sticky. Naively, this prevents us from using leader leases in this test, as replicas won't campaign if they don't have StoreLiveness support, which isn't kicked off until the first tick. Conveniently, raft fortification is yet another way to keep leadership sticky -- so explicitly using leader leases should achieve the same goal. References cockroachdb#133763 Release note: None
This test sets a very large number for RaftElectionTimeoutTicks to keep leadership sticky. Naively, this prevents us from using leader leases in this test, as replicas won't campaign if they don't have StoreLiveness support, which isn't kicked off until the first tick. Conveniently, raft fortification is yet another way to keep leadership sticky -- so explicitly using leader leases should achieve the same goal. References cockroachdb#133763 Release note: None
We'll soon enable leader leases metamorphically. There's a few tests that want to always use a lease type that allows for quiescence -- so instead of disabling expiration based leases, they should instead explicitly set its lease type to be epoch based. The tests are: - TestFlowControlUnquiescedRangeV2 - TestFlowControlUnquiescedRange - TestFlowControlQuiescedRange References cockroachdb#133763 Release note: None
Much like the previous commits, a bunch of other tests were setting a very large number for RaftElectionTimeoutTicks to keep leadership sticky. Naively, this prevents us from using leader leases in these tests, as replicas won't campaign unless they have StoreLiveness support, which they won't until the first tick kicks off a request. Conveniently, raft fortification is yet another way to keep leadership sticky -- so explicitly using leader leases should achieve the same goal. The tests modified here are: - TestFlowControlSendQueue - TestFlowControlRepeatedlySwitchMode - TestFlowControlRaftSnapshot - TestFlowControlRaftTransportBreak - TestFlowControlAdmissionPostSplitMergeV2 - TestFlowControlV1ToV2Transition References cockroachdb#133763 Release note: None
Member
|
This change is |
Collaborator
Author
|
At one point, I got tired of pulling things out into their own commits and decided to batch. I was too lazy to go back and batch the first few commits, so unless you (@kvoli, @iskettaneh) care about the lack of uniformity, here we are. |
kvoli
approved these changes
Nov 26, 2024
Contributor
kvoli
left a comment
kvoli
left a comment
There was a problem hiding this comment.
No testing diffs in .../kvserver/testdata/flow_control_integration_v2/* + passing tests is good indication that these changes had little discernible impact on rac2.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh)
Collaborator
Author
|
TFTR! bors r=kvoli |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.