roachtest: tpcc/large-schema-benchmark not emitting histogram#136575
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 3, 2024
Merged
roachtest: tpcc/large-schema-benchmark not emitting histogram#136575craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
sambhav-jain-16
requested review from
DarrylWong,
fqazi and
vidit-bhat
and removed request for
a team
Member
|
This change is |
fqazi
approved these changes
Dec 3, 2024
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @vidit-bhat)
fqazi
approved these changes
Dec 3, 2024
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
@sambhav-jain-16 Looks good!
Reviewable status:
sambhav-jain-16
commented
Dec 3, 2024
pkg/cmd/roachtest/tests/tpcc.go
Outdated
Contributor
Author
There was a problem hiding this comment.
Since the other openmetrics related flags also shouldn't be set when histogram is disabled.
Including the change here itself.
Contributor
Author
|
TFTR ! bors r=@fqazi |
Contributor
|
Build failed: |
Contributor
Author
|
Unit test failure seems to be unrelated. Running bors again |
Contributor
Author
|
bors r=@fqazi |
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
Author
|
I'll wait for #136583 to get merged for CI to get fixed. |
Contributor
Author
|
bors cancel |
Contributor
|
Canceled. |
`tpcc/large-schema-benchmark` stopped emitting benchmark file after cockroachdb#133035. It was discovered that after `DisableHistogram` was set true for every case and therefore `runTPCC` was skipping setting up the histogram args. Epic: none Release note: None
sambhav-jain-16
force-pushed
the
large-schema-benchmark
branch
from
12dc86c to
e4b3a7d
Compare
Contributor
Author
|
bors retry |
Contributor
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tpcc/large-schema-benchmarkstopped emitting benchmark file after #133035. It was discovered thatDisableHistogramwas set true for every case and thereforerunTPCCwas skipping setting up the histogram args.Epic: none
Release note: None