Skip to content

Comments

release-24.3: changefeedccl: change cdc latency hist bucket sizes#136604

Merged
rharding6373 merged 1 commit intorelease-24.3from
blathers/backport-release-24.3-136265
Dec 4, 2024
Merged

release-24.3: changefeedccl: change cdc latency hist bucket sizes#136604
rharding6373 merged 1 commit intorelease-24.3from
blathers/backport-release-24.3-136265

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Dec 3, 2024

Backport 1/1 commits from #136265 on behalf of @rharding6373.

/cc @cockroachdb/release


Increases the changefeed.admit_latency and changefeed.commit_latency max
from 5m to 60m and decreases their min to 5ms.

The metrics changefeed.parallel_io_queue_nanos,
changefeed.parallel_io_result_queue_nanos,
changefeed.sink_batch_hist_nanos,
changefeed.flush_hist_nanos, and
changefeed.kafka_throttling_hist_nanos have the new limits 5ms to 10m
(previously 500ms to 5m).

Epic: none
Fixes: #134593

Release note (general change): In order to improve the granularity of
changefeed pipeline metrics, the changefeed metrics
changefeed.admit_latency and changefeed.commit_latency have histogram
buckets from 5ms to 60m (previously 500ms to 5m). The changefeed
metrics changefeed.parallel_io_queue_nanos,
changefeed.parallel_io_result_queue_nanos,
changefeed.sink_batch_hist_nanos,
changefeed.flush_hist_nanos, and
changefeed.kafka_throttling_hist_nanos have histogram buckets from 5ms
to 10m (previously 500ms to 5m).


Release justification: Allows better granularity of changefeed metrics for debugging purposes.

Increases the changefeed.admit_latency and changefeed.commit_latency max
from 5m to 60m and decreases their min to 5ms.

The metrics changefeed.parallel_io_queue_nanos,
changefeed.parallel_io_result_queue_nanos,
changefeed.sink_batch_hist_nanos,
changefeed.flush_hist_nanos, and
changefeed.kafka_throttling_hist_nanos have the new limits 5ms to 10m
(previously 500ms to 5m).

Epic: none
Fixes: #134593

Release note (general change): In order to improve the granularity of
changefeed pipeline metrics, the changefeed metrics
changefeed.admit_latency and changefeed.commit_latency have histogram
buckets from 5ms to 60m (previously  500ms to 5m). The changefeed
metrics changefeed.parallel_io_queue_nanos,
changefeed.parallel_io_result_queue_nanos,
changefeed.sink_batch_hist_nanos,
changefeed.flush_hist_nanos, and
changefeed.kafka_throttling_hist_nanos have histogram buckets from 5ms
to 10m (previously 500ms to 5m).
@blathers-crl blathers-crl bot requested review from a team as code owners December 3, 2024 18:15
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-136265 branch from ed0da5d to 77c4924 Compare December 3, 2024 18:15
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 3, 2024
@blathers-crl blathers-crl bot requested review from kyle-a-wong and removed request for a team December 3, 2024 18:15
@blathers-crl blathers-crl bot requested review from aa-joshi, andyyang890, arjunmahishi, asg0451 and rharding6373 and removed request for a team December 3, 2024 18:15
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 3, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 3, 2024
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 3, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rharding6373 rharding6373 merged commit 68e22d0 into release-24.3 Dec 4, 2024
@rharding6373 rharding6373 deleted the blathers/backport-release-24.3-136265 branch December 4, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-cdc v24.3.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants