release-24.3: changefeedccl: change cdc latency hist bucket sizes#136604
Merged
rharding6373 merged 1 commit intorelease-24.3from Dec 4, 2024
Merged
release-24.3: changefeedccl: change cdc latency hist bucket sizes#136604rharding6373 merged 1 commit intorelease-24.3from
rharding6373 merged 1 commit intorelease-24.3from
Conversation
Increases the changefeed.admit_latency and changefeed.commit_latency max from 5m to 60m and decreases their min to 5ms. The metrics changefeed.parallel_io_queue_nanos, changefeed.parallel_io_result_queue_nanos, changefeed.sink_batch_hist_nanos, changefeed.flush_hist_nanos, and changefeed.kafka_throttling_hist_nanos have the new limits 5ms to 10m (previously 500ms to 5m). Epic: none Fixes: #134593 Release note (general change): In order to improve the granularity of changefeed pipeline metrics, the changefeed metrics changefeed.admit_latency and changefeed.commit_latency have histogram buckets from 5ms to 60m (previously 500ms to 5m). The changefeed metrics changefeed.parallel_io_queue_nanos, changefeed.parallel_io_result_queue_nanos, changefeed.sink_batch_hist_nanos, changefeed.flush_hist_nanos, and changefeed.kafka_throttling_hist_nanos have histogram buckets from 5ms to 10m (previously 500ms to 5m).
ed0da5d to
77c4924
Compare
Author
|
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
Author
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
asg0451
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #136265 on behalf of @rharding6373.
/cc @cockroachdb/release
Increases the changefeed.admit_latency and changefeed.commit_latency max
from 5m to 60m and decreases their min to 5ms.
The metrics changefeed.parallel_io_queue_nanos,
changefeed.parallel_io_result_queue_nanos,
changefeed.sink_batch_hist_nanos,
changefeed.flush_hist_nanos, and
changefeed.kafka_throttling_hist_nanos have the new limits 5ms to 10m
(previously 500ms to 5m).
Epic: none
Fixes: #134593
Release note (general change): In order to improve the granularity of
changefeed pipeline metrics, the changefeed metrics
changefeed.admit_latency and changefeed.commit_latency have histogram
buckets from 5ms to 60m (previously 500ms to 5m). The changefeed
metrics changefeed.parallel_io_queue_nanos,
changefeed.parallel_io_result_queue_nanos,
changefeed.sink_batch_hist_nanos,
changefeed.flush_hist_nanos, and
changefeed.kafka_throttling_hist_nanos have histogram buckets from 5ms
to 10m (previously 500ms to 5m).
Release justification: Allows better granularity of changefeed metrics for debugging purposes.