Skip to content

release-23.2: changefeedccl: change cdc latency hist bucket sizes #136618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rharding6373 merged 1 commit into from
Dec 4, 2024
Merged

release-23.2: changefeedccl: change cdc latency hist bucket sizes #136618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/ccl/changefeedccl/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,15 +906,15 @@ func newAggregateMetrics(histogramWindow time.Duration, lookup *cidr.Lookup) *Ag
Duration: histogramWindow,
MaxVal: changefeedIOQueueMaxLatency.Nanoseconds(),
SigFigs: 2,
BucketConfig: metric.BatchProcessLatencyBuckets,
BucketConfig: metric.ChangefeedBatchLatencyBuckets,
}),
ParallelIOPendingRows: b.Gauge(metaChangefeedParallelIOPendingRows),
ParallelIOResultQueueNanos: b.Histogram(metric.HistogramOptions{
Metadata: metaChangefeedParallelIOResultQueueNanos,
Duration: histogramWindow,
MaxVal: changefeedIOQueueMaxLatency.Nanoseconds(),
SigFigs: 2,
BucketConfig: metric.BatchProcessLatencyBuckets,
BucketConfig: metric.ChangefeedBatchLatencyBuckets,
}),
ParallelIOInFlightKeys: b.Gauge(metaChangefeedParallelIOInFlightKeys),
SinkIOInflight: b.Gauge(metaChangefeedSinkIOInflight),
Expand All @@ -923,28 +923,28 @@ func newAggregateMetrics(histogramWindow time.Duration, lookup *cidr.Lookup) *Ag
Duration: histogramWindow,
MaxVal: changefeedBatchHistMaxLatency.Nanoseconds(),
SigFigs: 1,
BucketConfig: metric.BatchProcessLatencyBuckets,
BucketConfig: metric.ChangefeedBatchLatencyBuckets,
}),
FlushHistNanos: b.Histogram(metric.HistogramOptions{
Metadata: metaChangefeedFlushHistNanos,
Duration: histogramWindow,
MaxVal: changefeedFlushHistMaxLatency.Nanoseconds(),
SigFigs: 2,
BucketConfig: metric.BatchProcessLatencyBuckets,
BucketConfig: metric.ChangefeedBatchLatencyBuckets,
}),
CommitLatency: b.Histogram(metric.HistogramOptions{
Metadata: metaCommitLatency,
Duration: histogramWindow,
MaxVal: commitLatencyMaxValue.Nanoseconds(),
SigFigs: 1,
BucketConfig: metric.BatchProcessLatencyBuckets,
BucketConfig: metric.ChangefeedPipelineLatencyBuckets,
}),
AdmitLatency: b.Histogram(metric.HistogramOptions{
Metadata: metaAdmitLatency,
Duration: histogramWindow,
MaxVal: admitLatencyMaxValue.Nanoseconds(),
SigFigs: 1,
BucketConfig: metric.BatchProcessLatencyBuckets,
BucketConfig: metric.ChangefeedPipelineLatencyBuckets,
}),
BackfillCount: b.Gauge(metaChangefeedBackfillCount),
BackfillPendingRanges: b.Gauge(metaChangefeedBackfillPendingRanges),
Expand Down
18 changes: 18 additions & 0 deletions pkg/util/metric/histogram_buckets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,24 @@ var BatchProcessLatencyBuckets = staticBucketConfig{
distribution: Exponential,
}

var ChangefeedBatchLatencyBuckets = staticBucketConfig{
category: "ChangefeedBatchLatencyBuckets",
min: 5e6, // 5ms
max: 600e9, // 10m
count: 60,
units: LATENCY,
distribution: Exponential,
}

var ChangefeedPipelineLatencyBuckets = staticBucketConfig{
category: "ChangefeedPipelineLatencyBuckets",
min: 5e6, // 5ms
max: 3600e9, // 1h
count: 60,
units: LATENCY,
distribution: Exponential,
}

var LongRunning60mLatencyBuckets = staticBucketConfig{
category: "LongRunning60mLatencyBuckets",
min: 500e6, // 500ms
Expand Down