Skip to content

release-24.3: catalog/lease: deflake TestDescriptorRefreshOnRetry#137128

Merged
rafiss merged 1 commit intorelease-24.3from
blathers/backport-release-24.3-137059
Dec 11, 2024
Merged

release-24.3: catalog/lease: deflake TestDescriptorRefreshOnRetry#137128
rafiss merged 1 commit intorelease-24.3from
blathers/backport-release-24.3-137059

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Dec 10, 2024

Backport 1/1 commits from #137059 on behalf of @rafiss.

/cc @cockroachdb/release


The test was flaky since the background thread to refresh leases could run and cause the acquisition counts to be off.

fixes #137033
Release note: None


Release justification: test only change

The test was flaky since the background thread to refresh leases could
run and cause the acquisition counts to be off.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 10, 2024 20:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-137059 branch from bad6750 to 46e2b3e Compare December 10, 2024 20:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 10, 2024
@blathers-crl blathers-crl bot requested a review from spilchen December 10, 2024 20:02
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 10, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 10, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit 00b09c8 into release-24.3 Dec 11, 2024
@rafiss rafiss deleted the blathers/backport-release-24.3-137059 branch December 11, 2024 15:22
@crl-codesys-jira crl-codesys-jira added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) v24.3.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants