drtprod: use roachprod Initialize instead of shell #138154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nameisbhaskar
force-pushed
the
drtprod-roachprod
branch
2 times, most recently
from
9201767 to
bd90630
Compare
nameisbhaskar
changed the title
nameisbhaskar
force-pushed
the
drtprod-roachprod
branch
from
bd90630 to
c4d9c53
Compare
With the recent refactoring of roachprod, it is possible to directly invoke the roachprod go code rather than using the shell command. This PR changes the same. Also, this PR changes all the scripts in drtprod to use "drtprod" binary instead of "roachprod" as this can work without compiling rochprod. Note that the YAML processor still uses the shell command as the input is not cobra. So, this becomes a bigger change. Epic: none Release note: None
nameisbhaskar
force-pushed
the
drtprod-roachprod
branch
from
c4d9c53 to
c07d02d
Compare
nameisbhaskar
requested review from
vidit-bhat and
csgourav
and removed request for
a team
shailendra-patel
approved these changes
Jan 8, 2025
|
Thanks @shailendra-patel for reviewing the change! |
|
bors r=@shailendra-patel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent refactoring of roachprod, it is possible to directly invoke the roachprod go code rather than using the shell command. This PR changes the same. Also, this PR changes all the scripts in drtprod to use "drtprod" binary instead of "roachprod" as this can work without compiling rochprod.
Note that the YAML processor still uses the shell command as the input is not cobra. So, this becomes a bigger change.
Epic: none
Release note: None