-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
licences: update THIRD-PARTY-NOTICES.txt #139026
Conversation
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't gone through the whole file yet. But upon a quick skim, I no longer see licenses for these packages, even thought they're still in go.mod:
Package Title: asm2plan9s (cdd76441f9d8c17c52d85f7657da5e8ce55f6083)
Package Title: asmfmt (ef134b9cec704e2b7b336fb02153b7d1a58247da)
Package Title: atime (ba95caf97c0b346727855dcc13d9cee7d44180e5)
e.g.
https://github.com/cockroachdb/cockroach/blob/master/go.mod#L392
Hmmmmm. This is concerning... Let me poke around. |
Looks like it's missing in 24.3 as well. Probably something to do with FOSSA. |
Fixes: REL-1744 Release note: None
dec414c
to
d8cca5d
Compare
I verified the removals and they look legit. The removed modules are not bundled with the cockroach binary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for digging into the generation process and confirming that the changes are correct and expected!
bors r=celiala |
Fixes: REL-1744
Release note: None