Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

licences: update THIRD-PARTY-NOTICES.txt #139026

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

rail
Copy link
Member

@rail rail commented Jan 14, 2025

Fixes: REL-1744
Release note: None

@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-release T-release Release Engineering & Automation Team labels Jan 14, 2025
@rail rail requested review from jlinder and celiala January 14, 2025 15:05
@rail rail self-assigned this Jan 14, 2025
@rail rail requested a review from a team as a code owner January 14, 2025 15:05
Copy link

blathers-crl bot commented Jan 14, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gone through the whole file yet. But upon a quick skim, I no longer see licenses for these packages, even thought they're still in go.mod:

Package Title: asm2plan9s (cdd76441f9d8c17c52d85f7657da5e8ce55f6083)
Package Title: asmfmt (ef134b9cec704e2b7b336fb02153b7d1a58247da)
Package Title: atime (ba95caf97c0b346727855dcc13d9cee7d44180e5)

e.g.
https://github.com/cockroachdb/cockroach/blob/master/go.mod#L392

@rail
Copy link
Member Author

rail commented Jan 14, 2025

I haven't gone through the whole file yet. But upon a quick skim, I no longer see licenses for these packages, even thought they're still in go.mod:

Package Title: asm2plan9s (cdd76441f9d8c17c52d85f7657da5e8ce55f6083) Package Title: asmfmt (ef134b9cec704e2b7b336fb02153b7d1a58247da) Package Title: atime (ba95caf97c0b346727855dcc13d9cee7d44180e5)

e.g. master/go.mod#L392

Hmmmmm. This is concerning... Let me poke around.

@rail
Copy link
Member Author

rail commented Jan 14, 2025

I haven't gone through the whole file yet. But upon a quick skim, I no longer see licenses for these packages, even thought they're still in go.mod:
Package Title: asm2plan9s (cdd76441f9d8c17c52d85f7657da5e8ce55f6083) Package Title: asmfmt (ef134b9cec704e2b7b336fb02153b7d1a58247da) Package Title: atime (ba95caf97c0b346727855dcc13d9cee7d44180e5)
e.g. master/go.mod#L392

Hmmmmm. This is concerning... Let me poke around.

Looks like it's missing in 24.3 as well. Probably something to do with FOSSA.

Fixes: REL-1744
Release note: None
@rail rail force-pushed the update-third-party-notices branch from dec414c to d8cca5d Compare January 17, 2025 18:51
@rail
Copy link
Member Author

rail commented Jan 17, 2025

I verified the removals and they look legit. The removed modules are not bundled with the cockroach binary.

@rail rail requested a review from celiala January 17, 2025 18:53
@rail rail added the backport-25.1.x Flags PRs that need to be backported to 25.1 label Jan 17, 2025
Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for digging into the generation process and confirming that the changes are correct and expected!

@rail
Copy link
Member Author

rail commented Jan 17, 2025

bors r=celiala

@craig craig bot merged commit f94a89b into cockroachdb:master Jan 17, 2025
22 checks passed
@rail rail deleted the update-third-party-notices branch January 17, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release backport-25.1.x Flags PRs that need to be backported to 25.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-release Release Engineering & Automation Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants