Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: show job messages on the job detail page #139246

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

dt
Copy link
Member

@dt dt commented Jan 16, 2025

Release note (ui change): Jobs can now choose to emit messages that are shown on the job detail page in 25.1+.

Epic: none.

Screenshot 2025-01-16 at 14 46 12

@dt dt requested a review from kev-cao January 16, 2025 19:46
@dt dt requested a review from a team as a code owner January 16, 2025 19:46
@dt dt requested review from kyle-a-wong and removed request for a team January 16, 2025 19:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@kev-cao kev-cao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
Release note (ui change): Jobs can now choose to emit messages that are shown on the job detail page in 25.1+.

Epic: none.
@dt
Copy link
Member Author

dt commented Jan 17, 2025

TFTR!

bors r+

@craig craig bot merged commit f94a89b into cockroachdb:master Jan 17, 2025
21 of 22 checks passed
@dt dt deleted the jobs-log-on-ui branch January 17, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants