Skip to content

Conversation

@dhartunian
Copy link
Collaborator

@dhartunian dhartunian commented Feb 27, 2025

On the left: the metrics you know and love in DB Console
On the right: prometheus endpoint with same metrics split by label.

Screenshot 2025-02-27 at 15 54 47

This is the minimum viable implementation that enables this. Some challenges to note:

  • Raw manipulation of Metadata.Name is very problematic. There are other parts of the codebase that do this.
  • When combining metrics into a single name w/ labels, it's crucial to make sure that the sum of the labeled metrics rolls up into a coherent thing. It's easy to combine, say, two different counts into a single metric where the sum is nonsense.

@dhartunian dhartunian added the do-not-merge bors won't merge a PR with this label. label Feb 27, 2025
@dhartunian dhartunian requested review from a team as code owners February 27, 2025 20:56
@dhartunian dhartunian requested review from Abhinav1299, aa-joshi, arjunmahishi and xinhaoz and removed request for a team February 27, 2025 20:56
@blathers-crl
Copy link

blathers-crl bot commented Feb 27, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian
Copy link
Collaborator Author

Closing in favor of #143511 which will merge this work.

@dhartunian dhartunian closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge bors won't merge a PR with this label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants