parser: remove IMPORT TABLE and IMPORT non-INTO support #148248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGDUMP and MYSQLDUMP code is now being removed, so remove the parser support. Release note (sql change): IMPORT TABLE as well PGDUMP and MYSQLDUMP formats of IMPORT are now fully removed. These have been deprecated since 23.2.
Also update one spot under assumption that `tree.Import.Table` is now always non-nil. Release note: None
yuzefovich
requested review from
a team and
jeffswenson
and removed request for
a team
Member
|
This change is |
mgartner
approved these changes
Jun 16, 2025
Collaborator
mgartner
left a comment
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
Member
Author
|
Thanks for the review! bors r+ |
Contributor
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parser: remove IMPORT TABLE and IMPORT non-INTO support
PGDUMP and MYSQLDUMP code is now being removed, so remove the parser support.
Release note (sql change): IMPORT TABLE as well PGDUMP and MYSQLDUMP
formats of IMPORT are now fully removed. These have been deprecated
since 23.2.
tree: remove unused Into and Bundle fields of Import
Also update one spot under assumption that
tree.Import.Tableis nowalways non-nil.
Epic: None