importer: purge all PGDUMP and MYSQLDUMP related code #148400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All this code is no longer used. Note that there are still some more things to clean up (like we can assume that no tables are new, and we don't need to support creating new schemas in IMPORT either), but all those things will be addressed separately. This commit focuses only on removing the related workload readers as well as the roachpb formats. Release note: None
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Member
Author
|
In my WIP #147191 this change is separated into two commits - please let me know if that'd be easier to review. |
mgartner
approved these changes
Jun 17, 2025
Collaborator
mgartner
left a comment
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
Member
Author
|
Thanks for the review! bors r+ |
Contributor
|
Build succeeded: |
celeste-cockroachdb
bot
added
v25.3.0-prerelease
and removed
target-release-25.3.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this code is no longer used. Note that there are still some more things to clean up (like we can assume that no tables are new, and we don't need to support creating new schemas in IMPORT either), but all those things will be addressed separately. This commit focuses only on removing the related workload readers as well as the roachpb formats.
Epic: None
Release note: None