Skip to content

Conversation

@yuzefovich
Copy link
Member

Removed unused version field and fix up a comment.

Epic: None
Release note: None

Removed unused version field and fix up a comment.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Jun 17, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich requested a review from michae2 June 17, 2025 04:30
@yuzefovich yuzefovich marked this pull request as ready for review June 17, 2025 04:30
@yuzefovich yuzefovich requested a review from a team as a code owner June 17, 2025 04:30
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 17, 2025

@craig craig bot merged commit fd18c1b into cockroachdb:master Jun 17, 2025
21 of 22 checks passed
@yuzefovich yuzefovich deleted the expression-cleanup branch June 17, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants