Skip to content

release-25.1: roachtest: more CPU profiling in rebalancing tests #148677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

release-25.1: roachtest: more CPU profiling in rebalancing tests #148677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/cmd/roachtest/tests/rebalance_load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ func registerRebalanceLoad(r registry.Registry) {
settings.ClusterSettings["kv.allocator.load_based_rebalancing"] = rebalanceMode
settings.ClusterSettings["kv.range_split.by_load_enabled"] = "false"

// Take a 10s profile every minute.
settings.ClusterSettings["server.cpu_profile.duration"] = "10s"
settings.ClusterSettings["server.cpu_profile.interval"] = "1m"
settings.ClusterSettings["server.cpu_profile.cpu_usage_combined_threshold"] = "1" // basically always true
settings.ClusterSettings["server.cpu_profile.total_dump_size_limit"] = "256 MiB"

if mixedVersion {
mvt := mixedversion.NewTest(ctx, t, t.L(), c, roachNodes, mixedversion.NeverUseFixtures,
mixedversion.ClusterSettingOption(
Expand All @@ -117,8 +123,6 @@ func registerRebalanceLoad(r registry.Registry) {
})
mvt.Run()
} else {
// Note that CPU profiling is already enabled by default, should there be
// a failure it will be available in the artifacts.
c.Start(ctx, t.L(), startOpts, settings, roachNodes)
require.NoError(t, rebalanceByLoad(
ctx, t, t.L(), c, rebalanceMode, maxDuration,
Expand Down