Skip to content

Conversation

@jbowens
Copy link
Collaborator

@jbowens jbowens commented Sep 9, 2025

Changes:

  • 342d2e8b db: add high-priority blob file rewrite compactions
  • fff7d3ad db: fix MarkedForCompaction flake
  • d86f6dab scripts: more improvements to stress.sh

Release note: none.
Epic: none.

Add a new cluster setting for configuring high-priority blob file rewrite
compactions. One of these compactions is allowed to run ahead of a default
compaction if the amount of garbage exceeds the configured percentage.

Changes:

 * [`342d2e8b`](cockroachdb/pebble@342d2e8b) db: add high-priority blob file rewrite compactions
 * [`fff7d3ad`](cockroachdb/pebble@fff7d3ad) db: fix MarkedForCompaction flake
 * [`d86f6dab`](cockroachdb/pebble@d86f6dab) scripts: more improvements to stress.sh

Release note: none.
Epic: none.
@blathers-crl
Copy link

blathers-crl bot commented Sep 9, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

…gh_priority

Add a new cluster setting for configuring high-priority blob file rewrite
compactions. One of these compactions is allowed to run ahead of a default
compaction if the amount of garbage exceeds the configured percentage.

Epic: none
Release note: none
@jbowens jbowens force-pushed the jackson/pebble-master-342d2e8b9a0b branch from de50543 to 95d9475 Compare September 9, 2025 21:57
@jbowens jbowens marked this pull request as ready for review September 9, 2025 23:07
@jbowens jbowens requested review from a team as code owners September 9, 2025 23:07
@jbowens jbowens requested a review from xinhaoz September 9, 2025 23:07
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 10, 2025

TFTR!

bors r=RaduBerinde

@craig
Copy link
Contributor

craig bot commented Sep 10, 2025

@craig craig bot merged commit 95e1d21 into cockroachdb:master Sep 10, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants