kvserver: deflake TestStoreRangeLease #160606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test failed with
client_lease_test.go:124: expected lease type LeaseLeader; got
repl=(n1,s1):1 seq=1 start=0,0 type=LeaseExpiration
exp=1766221308.352665601,0 pro=1766221302.352665601,0 acq=Request for
key "c"
It seems what is happening here is there is a period after the split on
the RHS where the range does not yet know the leader and thus the lease
acquisition attempt results in a expiration-based lease.
Here, I simply wait for the raft state to list any leader. This resolved
my local reproduction.
Fixes cockroachdb#159959
Release note: None
Member
|
This change is |
arulajmani
approved these changes
Jan 8, 2026
Collaborator
arulajmani
left a comment
arulajmani
left a comment
There was a problem hiding this comment.
@arulajmani reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @stevendanna).
Collaborator
|
Should we backport this as well? |
stevendanna
added
backport-26.1.x
Collaborator
Author
|
bors r+ Added the backport label for the last few releases. |
Contributor
|
Build succeeded: |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #159959: branch-release-25.3, branch-release-25.4. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failed with
It seems what is happening here is there is a period after the split on the RHS where the range does not yet know the leader and thus the lease acquisition attempt results in a expiration-based lease.
Here, I simply wait for the raft state to list any leader. This resolved my local reproduction.
Fixes #159959
Release note: None