release-25.4: inspect: speed up tests via faster job adoption #160620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
Member
|
This change is |
I noticed that inspect tests were quite slow, so I added `jobs.NewTestingKnobsWithShortIntervals()` to all that start a server or a cluster, which significantly sped up things (from multiple minutes to under a minute when run sequentially). Release note: None
yuzefovich
force-pushed
the
backport25.4-160588
branch
from
c25f6e9 to
81f6766
Compare
blathers-crl
bot
added
the
backport-test-only
rafiss
added
T-sql-foundations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #160588.
/cc @cockroachdb/release
I noticed that inspect tests were quite slow, so I added
jobs.NewTestingKnobsWithShortIntervals()to all that start a server or a cluster, which significantly sped up things (from multiple minutes to under a minute when run sequentially).Epic: None
Release note: None
Release justification: test-only change.