Skip to content

Conversation

@KeithCh
Copy link
Contributor

@KeithCh KeithCh commented Jan 7, 2026

Omitting experimental sink type for TestChangefeedBackfillCheckpoint
since it is flaky and not officially supported.

Fixes: #159640
Release Note: none

@KeithCh KeithCh requested a review from log-head January 7, 2026 17:29
@KeithCh KeithCh requested a review from a team as a code owner January 7, 2026 17:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@KeithCh
Copy link
Contributor Author

KeithCh commented Jan 7, 2026

Ran this 20k times without a failure.

…eckpoint

Omitting experimental sink type for TestChangefeedBackfillCheckpoint
since it is flaky and not officially supported.

Fixes: cockroachdb#159640
Release note: none
@KeithCh KeithCh force-pushed the fix-TestChangefeedBackfillCheckpoint branch from a258f06 to 8533fe7 Compare January 7, 2026 17:38
Copy link
Contributor

@log-head log-head left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KeithCh KeithCh requested a review from andyyang890 January 7, 2026 18:25
}

// TODO(ssd): Tenant testing disabled because of use of DB()
// TODO(#159640): Add experimental sink type back after fixing the flakiness.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you either file a new issue to track re-enabling it or add the skipped-test and X-noreuse labels to the test failure issue?

@KeithCh
Copy link
Contributor Author

KeithCh commented Jan 7, 2026

bors r=andyyang890,log-head

1 similar comment
@KeithCh
Copy link
Contributor Author

KeithCh commented Jan 7, 2026

bors r=andyyang890,log-head

@craig
Copy link
Contributor

craig bot commented Jan 7, 2026

@craig craig bot merged commit 785856d into cockroachdb:master Jan 7, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl: TestChangefeedBackfillCheckpoint failed

4 participants