Skip to content

Return (response, error) #2 #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 17, 2015
Merged

Return (response, error) #2 #1710

merged 7 commits into from
Jul 17, 2015

Conversation

@tamird
Copy link
Contributor

@tamird tamird commented Jul 16, 2015

More work toward #1400.

@tbg tbg added the PTAL label Jul 16, 2015
bdarnell
bdarnell reviewed Jul 16, 2015
View reviewed changes
storage/range.go Outdated
Copy link
Contributor

@bdarnell bdarnell Jul 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a strange error message. How about panic(fmt.Sprintf("don't know how to handle command %T", args))

Copy link
Contributor Author

@tamird tamird Jul 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bdarnell
Copy link
Contributor

bdarnell commented Jul 16, 2015

LGTM

tamird added a commit that referenced this pull request Jul 17, 2015
@tamird
Merge pull request #1710 from tamird/return-replies-2
6efcb06 
Return (response, error) #2
@tamird tamird merged commit 6efcb06 into cockroachdb:master Jul 17, 2015
@tamird tamird deleted the return-replies-2 branch July 17, 2015 00:06
@tbg tbg removed the PTAL label Jul 17, 2015
tbg
tbg reviewed Jul 17, 2015
View reviewed changes
storage/range.go
Copy link
Member

@tbg tbg Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tamird @bdarnell @tbg