add pre-commit hook & convenience script to add it. fix some vet errors.

githooks/pre-commit

@@ -0,0 +1,13 @@
+#!/usr/bin/env bash
+
+# Exit on error.
+set -e
+
+echo "Running go vet..."
+go vet ./...
+
+echo "Running tests..."
+go test ./...
+
+echo "Running gofmt..."
+find . -name "*.go" | xargs gofmt -w

gossip/filter.go

@@ -69,7 +69,7 @@ func NewFilter(N uint32, B uint32, maxFP float64) (*Filter, error) {
 		return nil, fmt.Errorf("number of bits (%d) must be a divisor of 8", B)
 	}
 	if maxFP <= 0 || maxFP >= 1 {
-		return nil, fmt.Errorf("max false positives must be 0 <= maxFP < 1:", maxFP)
+		return nil, fmt.Errorf("max false positives must be 0 <= maxFP < 1: %f", maxFP)
 	}
 	M, K := computeOptimalValues(N, maxFP)
 	maxCount := uint32((1 << B) - 1)

gossip/filter_test.go

@@ -104,22 +104,22 @@ func TestSlots(t *testing.T) {
 	// Increment a slot and verify.
 	f.incrementSlot(0, 1)
 	if f.getSlot(0) != 1 {
-		t.Error("slot value %d != 1", f.getSlot(0))
+		t.Errorf("slot value %d != 1", f.getSlot(0))
 	}
 	// Increment past max count.
 	f.incrementSlot(0, int32(f.MaxCount))
 	if f.getSlot(0) != f.MaxCount {
-		t.Error("slot value should be max %d != %d", f.getSlot(0), f.MaxCount)
+		t.Errorf("slot value should be max %d != %d", f.getSlot(0), f.MaxCount)
 	}
 	// Decrement once.
 	f.incrementSlot(0, -1)
 	if f.getSlot(0) != f.MaxCount-1 {
-		t.Error("slot value should be max %d != %d", f.getSlot(0), f.MaxCount-1)
+		t.Errorf("slot value should be max %d != %d", f.getSlot(0), f.MaxCount-1)
 	}
 	// Decrement past 0.
 	f.incrementSlot(0, -int32(f.MaxCount))
 	if f.getSlot(0) != 0 {
-		t.Error("slot value should be max %d != 0", f.getSlot(0))
+		t.Errorf("slot value should be max %d != 0", f.getSlot(0))
 	}
 }
 
@@ -181,7 +181,7 @@ func TestFalsePositives(t *testing.T) {
 	empFP := float64(countFP) / float64(1000)
 	diff := math.Abs(probFP - empFP)
 	if diff/probFP > 0.50 {
-		t.Errorf("measured P(FP) > 50% different from expected %f vs. %f", diff, empFP)
+		t.Errorf("measured P(FP) > 50%% different from expected %f vs. %f", diff, empFP)
 	}
 }
 

initrepo.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+
+# Create symlinks to all git hooks in your own .git dir.
+echo "### Creating symlinks to our git hooks..."
+for f in $(ls -d githooks/*)
+do ln -s ../../$f .git/hooks
+done && ls -al .git/hooks | grep githooks
+echo ""