rocksdb: upgrade to 5.9.0 #20070
Merged
rocksdb: upgrade to 5.9.0 #20070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RocksDB 5.5, the correct way to build a portable binary was to disable SSE4.2. In RocksDB 5.6+ (specifically, since facebook/rocksdb#2199), the correct way to build a portable binary is to specify -DPORTABLE=ON; non-portable binaries otherwise pass -march=native to the compiler. Fixes cockroachdb#19909.
Member
|
This change is |
Contributor
Author
|
The rocksdb patch was applied on top of our cloned 5.9 branch: https://github.com/cockroachdb/rocksdb/commits/crl-release-5.9.0 |
Member
|
I'm open to trying this out. @bdarnell, thoughts? |
Contributor
|
Review status: 0 of 5 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try. This includes the patch for the DeleteRange-related corruption (see #19947).