Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: relax delays in the RFC process + clarify 'dust has settled' #20144

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

knz
Copy link
Contributor

@knz knz commented Nov 18, 2017

Fixes #20105.

@knz knz requested review from bdarnell and rytaft November 18, 2017 13:44
@knz knz requested a review from a team as a code owner November 18, 2017 13:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz force-pushed the 20171118-rfc-process branch 4 times, most recently from f76ebd8 to 0413860 Compare November 18, 2017 13:48
@knz
Copy link
Contributor Author

knz commented Nov 18, 2017

cc @vivekmenezes

@knz
Copy link
Contributor Author

knz commented Nov 18, 2017

I took the initiative to address Ben's concerns myself since I was the one who initiated the RFC process change under discussion.

@bdarnell
Copy link
Contributor

:lgtm:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@vivekmenezes
Copy link
Contributor

vivekmenezes commented Nov 18, 2017 via email

@rytaft
Copy link
Collaborator

rytaft commented Nov 18, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


docs/RFCS/README.md, line 61 at r1 (raw file):

   expertise area.

4. At some point, the author(s) and/or review coordinator will seek to

Who is the review coordinator? Is this person one of the designated reviewers?


Comments from Reviewable

@knz knz force-pushed the 20171118-rfc-process branch from 0413860 to b3f9aec Compare November 20, 2017 10:24
@knz
Copy link
Contributor Author

knz commented Nov 20, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


docs/RFCS/README.md, line 61 at r1 (raw file):

Previously, rytaft wrote…

Who is the review coordinator? Is this person one of the designated reviewers?

Added a paragraph to clarify.


Comments from Reviewable

@knz knz merged commit 3cbce44 into cockroachdb:master Nov 20, 2017
@knz knz deleted the 20171118-rfc-process branch November 20, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants