encryption: encrypt data written to disk by Distsql's temp engine. #25591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
mberhault
reviewed
May 17, 2018
pkg/cli/start.go
Outdated
| return err | ||
| } | ||
| if serverCfg.TempStorageConfig, err = initTempStorageConfig(ctx, serverCfg.Settings, stopper, serverCfg.Stores.Specs[0]); err != nil { | ||
| var useStore base.StoreSpec |
Contributor
There was a problem hiding this comment.
This section could use some comments.
pkg/base/config.go
Outdated
| } | ||
|
|
||
| // IsEmpty returns if TempStorageConfig is empty. | ||
| func (cfg TempStorageConfig) IsEmpty() bool { |
Contributor
There was a problem hiding this comment.
I'm not sure this is necessary. The call in start.go can be removed by just keeping track of the index into the spec list. The testserver.go use case can probably stay as it was.
Now whenever distsql's temp engine writes to disk, the data written will be encrypted. This commit is part of the `use encryption for all local disk usage (non-logs)`. Issue: cockroachdb#19783. Release note: None
Contributor
Author
|
@mberhault Is it good to go, Marc? |
Contributor
|
LGTM. Thank. |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 21, 2018
25591: encryption: encrypt data written to disk by Distsql's temp engine. r=windchan7 a=windchan7 Now whenever distsql's temp engine writes to disk, the data written will be encrypted. This commit is part of the `use encryption for all local disk usage (non-logs)`. Issue: #19783. Release note: None Co-authored-by: Victor Chen <victor@cockroachlabs.com>
Contributor
Build succeeded |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now whenever distsql's temp engine writes to disk, the data written will be
encrypted. This commit is part of the
use encryption for all local disk usage (non-logs).Issue: #19783.
Release note: None