storage: bump RaftTickInterval in TestReplicaLazyLoad #25642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#25430. Before this change, the `RaftTickInterval` in the test was so low that node liveness only had a few milliseconds to perform updates. This caused the test to be flaky, especially in cockroachdb#25281, which is slowing down all tests by changing from in-memory stores to on-disk stores. By bumping up the `RaftTickInterval` by an order of magnitude in the test, we give node liveness much more time to perform updates. Release note: None
|
This change is |
|
Verified it works through this build: Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 18, 2018
25642: storage: bump RaftTickInterval in TestReplicaLazyLoad r=nvanbenschoten a=nvanbenschoten Fixes #25430. Before this change, the `RaftTickInterval` in the test was so low that node liveness only had a few milliseconds to perform updates. This caused the test to be flaky, especially in #25281, which is slowing down all tests by changing from in-memory stores to on-disk stores. By bumping up the `RaftTickInterval` by an order of magnitude in the test, we give node liveness much more time to perform updates. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
|
Thanks, Nathan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25430.
Before this change, the
RaftTickIntervalin the test was so low thatnode liveness only had a few milliseconds to perform updates. This
caused the test to be flaky, especially in #25281, which is slowing
down all tests by changing from in-memory stores to on-disk stores. By
bumping up the
RaftTickIntervalby an order of magnitude in the test,we give node liveness much more time to perform updates.
Release note: None