sql: add pg_catalog.pg_shdescription #26474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This virtual table is required for compatibility with PGAdmin. Closes cockroachdb#26376. Release note: Added the pg_catalog.pg_shdescription table for compatibility with Postgres tools. Note that we do not support adding descriptions to shared database objects.
|
This change is |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 6, 2018
26223: sql: cleanups + new "project set" relop + ROWS FROM + local exec logic r=knz a=knz
This PR provides support for pg's "Project Set" logical plan operator, which underlies both the handling of set-generating functions (SRFs) and the `ROWS FROM` input SQL syntax.
Formally, this operator takes a relational operator R and a list of SRF applications L. Its semantics is a relation which performs a lateral cross join between R and (conceptually) `ROWS FROM (L)`, the functional zip of the value generators in L.
Reminder: the functional zip over iterators a,b,c returns tuples of values from a,b,c picked "simultaneously". NULLs are used when an iterator is "shorter" than another. For example `zip([1,2,3], ['a','b'])` is `[(1,'a'), (2,'b'), (3, null)]`.
The PR also greatly simplifies / clean up the typing logic around SRFs by getting rid of `TTable` and `DTable` entirely.
It also cleans up the docs of SRF built-in functions so that their return type is displayed in simple form (e.g. the documented return type of generate_series is now `int` and not `setof tuple{int as ...}`)
This PR serves several purposes simultaneously.
1. to solve #20511.
2. to provide more compatibility with pg's wrt the `ROWS FROM` syntax.
3. to serve as baseline for testing the new "ApplySRF" (really, "project set") functionality in distsql (SQL Execution team)
4. to serve as common intermediate language for the optimizer code, and as baseline for future
optimizer code that will look into SRF transformations (SQL Optimizer team). /cc @andy-kimball
Fixes #20511.
26474: sql: add pg_catalog.pg_shdescription r=BramGruneir a=BramGruneir
This virtual table is required for compatibility with PGAdmin.
Closes #26376.
Release note: Added the pg_catalog.pg_shdescription table for compatibility with
Postgres tools. Note that we do not support adding descriptions to shared
database objects.
Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Co-authored-by: Bram Gruneir <bram@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This virtual table is required for compatibility with PGAdmin.
Closes #26376.
Release note: Added the pg_catalog.pg_shdescription table for compatibility with
Postgres tools. Note that we do not support adding descriptions to shared
database objects.